Skip to content

Commit

Permalink
Added Fix for SublimationLifecycleHandler.didBoot (#23)
Browse files Browse the repository at this point in the history
  • Loading branch information
leogdion authored Apr 15, 2024
1 parent a19cedd commit 8d9d322
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/Sublimation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,24 @@ jobs:
iOSVersion: "17.0.1"
watchOSVersion: "10.0"
watchName: "Apple Watch Series 9 (41mm)"
iPhoneName: "iPhone 15 Pro"
iPhoneName: "iPhone 15"
- xcode: "/Applications/Xcode_15.1.app"
os: macos-13
iOSVersion: "17.2"
watchOSVersion: "10.2"
watchName: "Apple Watch Series 9 (45mm)"
iPhoneName: "iPhone 15 Pro"
iPhoneName: "iPhone 15 Plus"
- xcode: "/Applications/Xcode_15.2.app"
os: macos-14
iOSVersion: "17.2"
watchOSVersion: "10.2"
watchName: "Apple Watch Ultra (49mm)"
iPhoneName: "iPhone 15 Pro"
- xcode: "/Applications/Xcode_15.3.app"
os: macos-14
iOSVersion: "17.4"
watchOSVersion: "10.4"
watchName: "Apple Watch Ultra 2 (49mm)"
iPhoneName: "iPhone 15 Pro Max"
steps:
- uses: actions/checkout@v4
Expand All @@ -103,7 +109,7 @@ jobs:
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-${{ matrix.xcode }}-
- name: Cache mint
if: startsWith(matrix.xcode,'/Applications/Xcode_15.2')
if: startsWith(matrix.xcode,'/Applications/Xcode_15.3')
id: cache-mint
uses: actions/cache@v4
env:
Expand All @@ -120,7 +126,7 @@ jobs:
- name: Setup Xcode
run: sudo xcode-select -s ${{ matrix.xcode }}/Contents/Developer
- name: Install mint
if: startsWith(matrix.xcode,'/Applications/Xcode_15.2')
if: startsWith(matrix.xcode,'/Applications/Xcode_15.3')
run: |
brew update
brew install mint
Expand All @@ -142,7 +148,7 @@ jobs:
# files: ${{ join(fromJSON(steps.coverage-files.outputs.files), ',') }}
- name: Lint
run: ./scripts/lint.sh
if: startsWith(matrix.xcode,'/Applications/Xcode_15.2')
if: startsWith(matrix.xcode,'/Applications/Xcode_15.3')
# - name: Dump PIF
# if: startsWith(matrix.xcode,'/Applications/Xcode_14')
# run: |
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import PackageDescription

let swiftSettings: [SwiftSetting] = [
// .enableUpcomingFeature("BareSlashRegexLiterals"),
// .enableUpcomingFeature("BareSlashRegexLiterals"),
// .enableUpcomingFeature("ConciseMagicFile"),
// .enableUpcomingFeature("ExistentialAny"),
// .enableUpcomingFeature("ForwardTrailingClosures"),
Expand Down
2 changes: 2 additions & 0 deletions Sources/SublimationVapor/SublimationLifecycleHandler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ public actor SublimationLifecycleHandler<
}
}

public nonisolated func didBoot(_: Application) throws {}

/// Called when the application is shutting down.
///
/// - Parameters:
Expand Down

0 comments on commit 8d9d322

Please sign in to comment.