Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/yard documentation #85

Merged

Conversation

KonnorRogers
Copy link
Member

This is a 🙋 feature or enhancement.

Summary

Adds yard to Gemfile
Adds a Rake task in bridgetown-core for starting a YARD server.
Adds .yardoc to .gitignore

[bundle exec] rake yard:serve will create a local server at port 8808.
[bundle exec] rake yard:serve YARD_PORT="3000" will create a local server on port 3000.
[bundle exec] rake yard will generate documentation. Currently it is setup to only parse the files and not generate any documentation.

Provides YARD documentation for bridgetown-core/lib/bridgetown-core/site/concerns

Context

This is part of #47 to help improve internal documentation.

@KonnorRogers KonnorRogers requested a review from jaredcwhite July 2, 2020 05:41
@KonnorRogers KonnorRogers added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 2, 2020
Gemfile Outdated Show resolved Hide resolved
Copy link
Member

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fabulous! I noticed just a few small things to tweak and made comments. Otherwise LGTM 👍

(or you could keep the PR open if there's something else you want to update docs for…)

@KonnorRogers
Copy link
Member Author

Going to go ahead and squash and merge this. I'm not sure when I'll be documenting again, but I dont like leaving branches open as a personal preference. Ill open a new PR when the time comes :)

@KonnorRogers KonnorRogers merged commit 0e148db into bridgetownrb:main Jul 6, 2020
@KonnorRogers KonnorRogers deleted the feature/yard-documentation branch July 6, 2020 19:24
@jaredcwhite
Copy link
Member

Works for me. Thanks @ParamagicDev 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants