Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up esbuild version in new template and on the BT site #646

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

jaredcwhite
Copy link
Member

This bumps up the esbuild dep version 0.15.x.

@render
Copy link

render bot commented Oct 28, 2022

@render
Copy link

render bot commented Oct 28, 2022

@andrewmcodes
Copy link
Contributor

@KonnorRogers
Copy link
Member

KonnorRogers commented Nov 23, 2022

I haven't had time to look at this yet, but be careful with this one, 0.14.x -> 0.15.x I saw a breaking change with using relative file paths without "./"

I upgraded one of my library and had to add:

"." + path.sep

0.15.x -> https://github.com/KonnorRogers/bridgetown-quick-search/blob/df061f2fbdaddac2848f03807f01796fd356000e/esbuild.config.js#L12

0.14.x -> https://github.com/KonnorRogers/create-konnor-app/blob/fde3ec3003f2bbce77ce5ddbc2de85c78c6c3b0d/src/templates/browser-project/esbuild.config.js#L9

@andrewmcodes
Copy link
Contributor

I haven't had time to look at this yet, but be careful with this one, 0.14.x -> 0.15.x I saw a breaking change with using relative file paths without "./"

I upgraded one of my library and had to add:

"." + path.sep

I've been running 0.15.12 since it came out without issue until I tried switching to typescript and got an error about relative paths similar to what @KonnorRogers mentions.

Without the leading "./", the path "frontend/javascript/index.js"
  is being interpreted as a package path instead

but this change in the config fixed it and I haven't had any other issues.

-entryPoints: ["frontend/javascript/index.js"],
+entryPoints: ["./frontend/javascript/index.js"],

@jaredcwhite
Copy link
Member Author

@andrewmcodes @KonnorRogers OK I've added in the ./ at the start of the entryPoint, hopefully that's all we need to worry about.

@jaredcwhite jaredcwhite merged commit dc83906 into main Nov 30, 2022
@jaredcwhite jaredcwhite deleted the update-esbuild-0.15 branch November 30, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants