-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode #620
Dark mode #620
Conversation
@vvveebs This is fantastic! And going the extra mile to add the theme picker too. 👍🏻👍🏻 I'll review in more detail soon…would be awesome to roll this out along with Bridgetown 1.2. |
5a30287
to
8898d6b
Compare
8898d6b
to
6a8cbeb
Compare
ebe9dd1
to
4b8592f
Compare
@andrewmcodes thanks for the review! All good points. Responded to them in order:
themepickerbutton.mov
|
4b8592f
to
3aafd52
Compare
@vvveebs Looking gooood 🤩 |
@vvveebs I see some room for further tweaking, but I think it'll be better to reason about in followup issues/PRs. Going to go ahead and merge! Thanks again for this fabulous effort! |
This is a 🙋 feature or enhancement.
Summary
Adds a dark mode to the Bridgetown website.
Context
Closes #555
This implementation mainly reuses existing colors. An exception is made for meeting color contrast accessibility requirements though - see inline PR comment.
The styling will of course need various changes to match an actual design but this should hopefully form a basis.
Code syntax styling may be an area that needs extra attention.
Screenshots