Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #620

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Dark mode #620

merged 6 commits into from
Dec 7, 2022

Conversation

neilvanbeinum
Copy link
Contributor

@neilvanbeinum neilvanbeinum commented Sep 6, 2022

This is a 🙋 feature or enhancement.

Summary

Adds a dark mode to the Bridgetown website.

Context

Closes #555

This implementation mainly reuses existing colors. An exception is made for meeting color contrast accessibility requirements though - see inline PR comment.

The styling will of course need various changes to match an actual design but this should hopefully form a basis.

Code syntax styling may be an area that needs extra attention.

Screenshots

Light Mode Dark Mode
image image

@jaredcwhite
Copy link
Member

@vvveebs This is fantastic! And going the extra mile to add the theme picker too. 👍🏻👍🏻

I'll review in more detail soon…would be awesome to roll this out along with Bridgetown 1.2.

@jaredcwhite jaredcwhite added this to the 1.2 milestone Sep 6, 2022
@andrewmcodes
Copy link
Contributor

@vvveebs this is looking awesome! I really only found one issue and then there are a few things I want to get your thoughts on:

  1. The edge site banner appears to be the wrong color
    20221120211946Z_Safari_A Break from Summer Break to Bring You Bridgetown 0 21 1  Bridgetown  EDGE

  2. The theme picker is excellent but it's a little weird that it doesn't match the style of the rest of the buttons. I think it's ok but one thing I think we should change is that the hover color is blue but it would be nice if it matched the hover color of the dropdown items aka the bridgetown green. Wdyt?

  3. These buttons may look better without a border or with different shade of green for the border as opposed to white. Wdyt?
    20221120212911Z_Safari_Getting Started  Bridgetown  EDGE


2 & 3 are opinions so not a requirement to merge. Overall I think this look great, thank you so much for the contribution 👏

@neilvanbeinum neilvanbeinum force-pushed the dark-mode branch 2 times, most recently from ebe9dd1 to 4b8592f Compare December 1, 2022 07:33
@neilvanbeinum
Copy link
Contributor Author

neilvanbeinum commented Dec 1, 2022

@andrewmcodes thanks for the review! All good points. Responded to them in order:

  1. Edge site banner in dark mode updated.

image

  1. It's funny - I didn't even realise this button was so different - guess I'd been staring at it for a while and it became a blind spot! Updated.
themepickerbutton.mov
  1. After chat with Jared it seems like we want to go ahead with the border. But I agree straight up white is too much. Updated to a light green.

image

@jaredcwhite
Copy link
Member

@vvveebs Looking gooood 🤩

@jaredcwhite
Copy link
Member

@vvveebs I see some room for further tweaking, but I think it'll be better to reason about in followup issues/PRs. Going to go ahead and merge! Thanks again for this fabulous effort!

@jaredcwhite jaredcwhite merged commit 5610e66 into bridgetownrb:main Dec 7, 2022
@neilvanbeinum neilvanbeinum deleted the dark-mode branch December 8, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Add a dark mode
3 participants