Allow route classes to be prioritized to adjust run order #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-api-pr-538.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9g8qk10gd0a553nrjgg. |
|
Your Render PR Server URL is https://bridgetown-beta-pr-538.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9g8qk90gd0a553nrjk0. |
|
Builder priority feature was added as well, and priority logic was extracted to a concern. So now base plugins (converters, generators), builders, and routers all share similar logic. (Hooks are still an odd duck, but maybe there's a way to solve that too down the road.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, classes in
server/routeswould add to Roda's run block in "Zeitwerk" order…roughly alphabetical I'd guess. Now they're added (a) by priority, so you can ensure high priority routes are handled before low priority ones, and (b) alphabetical by class name within a single priority tier.In addition, we now have Rack/Roda/SSR integration testing in our test suite. 🎉 Lots more tests to follow!