Switch to streaming/event source mechanism for live reload #458
Conversation
|
Your Render PR Server URL is https://bridgetown-api-pr-458.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6d9gnp0gd04td1qnoh0. |
|
Your Render PR Server URL is https://bridgetown-beta-pr-458.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6d9go90gd04td1qnokg. |
|
Damn, sounds like you went down quite the rabbit hole with this one 😬. I'm not sure there's a tangible benefit to this approach for the added complexity though 🤷. I know you mentioned that on Twitter as well, but honestly just for the effort put in, if it works, we should probably go for it and see what happens!! |
| @interrupted = false | ||
|
|
||
| class << self | ||
| attr_accessor :interrupted |
There was a problem hiding this comment.
Can we use ActiveSupport's mattr_accessor here by any chance?
There was a problem hiding this comment.
Good question…I think mattr_accessor is particularly useful when object instances which have included a module want to access that module's accessor easily. No need for that here, so probably wouldn't need the overhead
|
Having done some work recently on a project without this PR and seeing |
Resolves #416 (maybe?)
Well this certainly ended up being an inordinate amount of work! Getting the streaming mechanism enabled wasn't too bad, but then I ran into a bad situation where Ctrl-C would hang until Puma determined the stream had completed (and the longer it would run, the longer it would hang!). It took quite a while to workaround that, and then I discovered long streams would also gunk up Puma's threads if enough pages were opened at once and you were clicking around, because of a delay between a page change and the socket (browser? Puma?) cleaning up and stopping the stream.
I think it's pretty balanced now, between the length of the stream before a browser-initiated reconnection and the interval checking the modification, as well as further modification checks in-browser between a previous stream and a reconnected stream. Good grief.
I tested in Safari and Firefox…haven't tried any other browsers yet.