A bit of a hooks refactor & cleaning up SSR reload hook #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-api-pr-457.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6ctngfd17c2tti7gsmg. |
|
Your Render PR Server URL is https://bridgetown-beta-pr-457.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6ctngvd17c2tti7gsq0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of a Hooks refactor, plus getting rid of the React-like "store a second hook via a proc returned from the original hook" weirdness in the SSR plugin (shudder…what was I thinking?!) in favor of using regular site hooks. (Speaking of which,
sitenow has a pretty niceonmethod…)Plus Hooks now has YARD documentation.
…OK, ended up refactoring Watcher as well. 😅