Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need pin ruby2js here. #442

Merged
merged 1 commit into from
Nov 9, 2021
Merged

No need pin ruby2js here. #442

merged 1 commit into from
Nov 9, 2021

Conversation

Eric-Guo
Copy link
Contributor

@Eric-Guo Eric-Guo commented Nov 8, 2021

it's introduced at #243

@jaredcwhite
Copy link
Member

Not sure what the purpose of this is.

@Eric-Guo
Copy link
Contributor Author

Eric-Guo commented Nov 9, 2021

I check again, found ruby2js is required by npm package webpacker-loader, anyway no need to pin regexp_parser version.

@jaredcwhite
Copy link
Member

Thanks, looks good to me. 👍

@jaredcwhite jaredcwhite merged commit a1a3fb6 into bridgetownrb:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eric-Guo @jaredcwhite