-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripping out all of the legacy content engine #415
Conversation
Your Render PR Server URL is https://bridgetown-beta-pr-415.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5gulh9g7hp0n5hp9o90. |
Your Render PR Server URL is https://bridgetown-api-pr-415.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5gulhpg7hp0n5hp9ofg. |
Latest status: fixed a few bugs or oversights with the resource engine, modified many tests in small ways to conform to the new way resources work (mostly around permalinks or template data models). I actually didn't have to fudge things in too many places which is pretty awesome. The main thing still "broken" (even though I hacked it to get the tests passing) is #332 needs to be implemented. Once I add that in, I think we'll be in good shape to merge this PR! |
Decided I'll work on #332 in its own PR, so I'll go ahead and merge this now. |
This is extremely WIP at present and likely to be broken (failing tests and possibly failing builds) for some time. I just want to get a PR up early to track progress on untangling all the legacy content engine stuff and removing it from the codebase.OK, made a ton of progress now! Further comments below… 🙌