Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping out all of the legacy content engine #415

Merged
merged 20 commits into from
Oct 14, 2021

Conversation

jaredcwhite
Copy link
Member

@jaredcwhite jaredcwhite commented Oct 9, 2021

This is extremely WIP at present and likely to be broken (failing tests and possibly failing builds) for some time. I just want to get a PR up early to track progress on untangling all the legacy content engine stuff and removing it from the codebase.

OK, made a ton of progress now! Further comments below… 🙌

@jaredcwhite jaredcwhite added process Improve the development process for the repo resource engine Related to the new Resource content engine labels Oct 9, 2021
@render
Copy link

render bot commented Oct 9, 2021

@render
Copy link

render bot commented Oct 9, 2021

@jaredcwhite jaredcwhite added this to the 1.0 milestone Oct 9, 2021
@jaredcwhite jaredcwhite changed the title WIP: Stripping out all of the legacy content engine Stripping out all of the legacy content engine Oct 13, 2021
@jaredcwhite
Copy link
Member Author

jaredcwhite commented Oct 13, 2021

Latest status: fixed a few bugs or oversights with the resource engine, modified many tests in small ways to conform to the new way resources work (mostly around permalinks or template data models). I actually didn't have to fudge things in too many places which is pretty awesome.

The main thing still "broken" (even though I hacked it to get the tests passing) is #332 needs to be implemented. Once I add that in, I think we'll be in good shape to merge this PR!

@jaredcwhite
Copy link
Member Author

Decided I'll work on #332 in its own PR, so I'll go ahead and merge this now.

@jaredcwhite jaredcwhite merged commit 9ac48ce into main Oct 14, 2021
@jaredcwhite jaredcwhite deleted the strip-out-legacy-engine branch October 14, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Improve the development process for the repo resource engine Related to the new Resource content engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant