Resolve postcss-focus-within to v4 #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in
postcss-focus-within
v3 which has been fixed in v4; butpostcss-present-env
still relies on v3. There's a PR open to update it for over a year: csstools/postcss-preset-env#172To provide a better developer experience, I reckon it's best to fix this within Bridgetown by explicitly resolving this package to v4. I've set the resolution in our default
package.json
. I don't think there's much point in adding this resolution just when the--use-postcss
flag is added as it doesn't really do any harm and I don't want to litter the file with multipleif
s.Also, this approach means we don't have to set the resolution in our
bridgetown webpack enable-postcss
command which makes life easier as theyarn set resolution
command only exists in Yarn 2.Fixes #356