Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve postcss-focus-within to v4 #366

Merged

Conversation

ayushn21
Copy link
Member

There's a bug in postcss-focus-within v3 which has been fixed in v4; but postcss-present-env still relies on v3. There's a PR open to update it for over a year: csstools/postcss-preset-env#172

To provide a better developer experience, I reckon it's best to fix this within Bridgetown by explicitly resolving this package to v4. I've set the resolution in our default package.json. I don't think there's much point in adding this resolution just when the --use-postcss flag is added as it doesn't really do any harm and I don't want to litter the file with multiple ifs.

Also, this approach means we don't have to set the resolution in our bridgetown webpack enable-postcss command which makes life easier as the yarn set resolution command only exists in Yarn 2.

Fixes #356

@ayushn21
Copy link
Member Author

Hey @jaredcwhite, could you please take a quick peek at this so we can merge it? Thanks! :)

@ayushn21 ayushn21 merged commit cc6aea5 into bridgetownrb:main Sep 8, 2021
@ayushn21 ayushn21 deleted the lock-postcss-focus-within-branch branch September 8, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind doesn't work when we use yarn deploy
1 participant