Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment-specific config and metadata support #34

Merged
merged 2 commits into from
May 4, 2020
Merged

Environment-specific config and metadata support #34

merged 2 commits into from
May 4, 2020

Conversation

jaredcwhite
Copy link
Member

This closes #28 by allowing the configuration file as well as the site metadata file to pull
YAML options out of a environment specific block. For example:

# src/_data/site_metadata.yml

title: My Website

development:
  title: My (DEV) Website

The site title would be "My Website" if built with a production environment,
and "My (DEV) Website" if built with a development environment.

Also did some much needed refactoring (and more is needed!) of Bridgetown::Configuration.

Tests and documentation added.

@jaredcwhite jaredcwhite added documentation Improvements or additions to documentation enhancement New feature or request labels May 4, 2020
@jaredcwhite jaredcwhite added this to the v0.13.0 "Klickitat" milestone May 4, 2020
@jaredcwhite
Copy link
Member Author

LGTM :shipit:

@jaredcwhite jaredcwhite merged commit 5d49305 into master May 4, 2020
@jaredcwhite jaredcwhite deleted the environment-specific-config branch May 4, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.13.0 "Klickitat"
Development

Successfully merging this pull request may close these issues.

feat: Environment-specific configuration/metadata
1 participant
@jaredcwhite