Remove safe_yaml gem in favour of using Psych which is in the stdlib #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! One question: is there a test to double-check it's really safe…like it can't instantiate a non-allowlisted object? |
I know it's safe because I ran into that error a number of times while working on this hahaha. But yeah definitely worth adding a test for this. Will write a couple of tests for |
|
Added some tests. Let me know what you think! |
|
@jaredcwhite heres some background on |
|
@ayushn21 Awssome! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
The
safe_yamlgem doesn't seem like it's maintained any more. ThePsychmodule which is part of the stdlib has asafe_loadmethod so we can drop that external dependency and use the stdlib directly.Context
Resolves #300