Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dart sass since node-sass is deprecated #279

Merged

Conversation

eclectic-coding
Copy link
Contributor

This is a 🙋 feature or enhancement, addressed in issues #278 and #273 to update the deprecated node-sass package.

Copy link
Member

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eclectic-coding! Just a couple of comments/questions and then we should be good to go.

bridgetown-core/lib/site_template/package.json.erb Outdated Show resolved Hide resolved
bridgetown-core/lib/site_template/package.json.erb Outdated Show resolved Hide resolved
@eclectic-coding
Copy link
Contributor Author

All requests have been resolved

@jaredcwhite jaredcwhite merged commit d9386d8 into bridgetownrb:main Apr 6, 2021
@jaredcwhite
Copy link
Member

I took fibers out of the package.json since it's optional and not used in this configuration.

@eclectic-coding
Copy link
Contributor Author

eclectic-coding commented Apr 6, 2021

@jaredcwhite Fibers is indicated in the webpack.config.js and is recommended for performance:
https://github.com/sass/dart-sass#javascript-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants