Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class declaration keyword in liquid tags and helpers docs #198

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

ayushn21
Copy link
Member

@ayushn21 ayushn21 commented Dec 8, 2020

This is a 🔦 documentation change.

Summary

Documentation fixes on the plugins/tags and plugins/helpers pages where it seems a class was declared with def. I've just replaced def with class.

This PR fixes #197

@jaredcwhite
Copy link
Member

Thanks @ayushn21! Do you mind addressing #197 as well and we can fix it all together? (There must have been a typo in an initial example and then it propagated around other parts of the helpers/filters/tags docs… 😬)

@ayushn21
Copy link
Member Author

ayushn21 commented Dec 8, 2020

Yup sure @jaredcwhite; will add those fixes in as well :)

@ayushn21
Copy link
Member Author

ayushn21 commented Dec 8, 2020

I've just pushed the fixes for the helpers page as well :)

@ayushn21 ayushn21 changed the title Fix class declaration keyword in liquid tags docs Fix class declaration keyword in liquid tags and helpers docs Dec 8, 2020
@jaredcwhite
Copy link
Member

@ayushn21 Niiiice 👍

@jaredcwhite jaredcwhite closed this Dec 9, 2020
@jaredcwhite jaredcwhite reopened this Dec 9, 2020
@jaredcwhite jaredcwhite merged commit f05a207 into bridgetownrb:main Dec 9, 2020
@ayushn21 ayushn21 deleted the fix-docs branch December 9, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Typos in docs/plugins/helpers#supporting-arguments
2 participants