Add inferred name attribute to default package.json #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushn21
changed the title
ayushn21
force-pushed
the
add-inferred-name-to-package
branch
2 times, most recently
from
d3e1a85 to
59d747a
Compare
ayushn21
force-pushed
the
add-inferred-name-to-package
branch
from
59d747a to
e0f065d
Compare
andrewmcodes
approved these changes
Nov 22, 2020
| @@ -60,7 +60,7 @@ def site_template_source | |||
| static_template_files = dir_contents(site_template).reject do |f| | |||
| File.extname(f) == ".erb" | |||
| end | |||
| static_template_files << "/Gemfile" | |||
| static_template_files.push "/Gemfile", "/package.json" | |||
There was a problem hiding this comment.
Definitely prefer your solution but fun fact:
static_template_files = []
=> []
static_template_files << "/Gemfile" << "/package.json"
=> ["/Gemfile", "/package.json"]There was a problem hiding this comment.
Ah nice, cheers! Didn't know that was valid syntax :)
|
Thanks @ayushn21! This is a great enhancement. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
✅ I've added tests (if it's a bug, feature or enhancement)
✅ The test suite passes locally (run
script/cibuildto verify this)Summary
When we create a new Bridgetown site, the default
package.jsonhas anameattribute ofbridgetown-new-site.I thought it would be a nicer developer experience if this name could be inferred from the path entered into the
newcommand. So this change takes the last path component of the input path and sets that as the name inpackage.json.