Change logging level for "Executing inline Ruby…" messages #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbayne
force-pushed
the
change/logging-level
branch
from
5035a5c to
c7cd4ec
Compare
ianbayne
force-pushed
the
change/logging-level
branch
from
c7cd4ec to
ba2cc7e
Compare
ianbayne
force-pushed
the
change/logging-level
branch
from
ba2cc7e to
a685c7a
Compare
ianbayne
changed the title
|
Thanks @ianbayne, your contribution is much appreciated! Look forward to future collabs. LGTM 👍 |
jaredcwhite
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I really like the idea of this project and your aims for it! I've got a Jekyll blog myself and I think it's really neat that Bridgetown fills a similar role, while at the same time being more in tune with the direction of the modern web (including webpack as a default, etc.). Additionally, the content of
CONTRIBUTING.mdandPULL_REQUEST_TEMPLATE.mdis very well written, and it's quite ingenious of you to let contributors include mention of themselves in theREADME.md. I guess you could say that I'm just impressed all around 😄This is a 🙋 feature or enhancement.
Summary
This is just a very small PR to get my feet wet with Bridgetown. It doesn't add any tests, but as it's just a simple change to the logging level, I don't feel that tests are warranted.
Context
Closes #175.