Convert ERB and Beyond docs to ERB and use capture helper for liquid_render #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus fix the `liquid_render` helper so it uses `capture`
jaredcwhite
added
bug
|
OK, I've had a love-hate relationship with RuboCop since this project started. As my first experience with both a large codebase and a complex linter setup predating my involvement, I really didn't want to rock the boat too much. But So I relaxed it a bit, which is already relaxed from the default RuboCop setting (17? SEVENTEEN??!!). I welcome feedback, but I'm very likely going to stick with this decision. :) |
jaredcwhite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be a good exercise to—y'know—make sure the "ERB and Beyond" documentation page is itself using ERB instead of Liquid. In doing so I discovered I needed to fix the
liquid_renderhelper so it usescapture. Will require a point release for 0.18.