Process data cascade for folder-based frontmatter defaults #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonnorRogers
reviewed
Sep 8, 2020
KonnorRogers
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Looks good. Super easy to follow, minimal changes made. If we could fix the failing tests (they actually produce errors not fail) we should be good to go.
It seems like we just have to adjust the value of site.source to fix where it searches for the src directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #50
This PR provides the ability to put a
_defaults.yml/yaml/jsonfile(s) anywhere in the source tree, which will then cause a "data cascade" — aka pages/documents will pull their front matter defaults from one or more defaults files in the tree with subfolders potentially overriding values from their parents.While this isn't a 100% replacement for the previous defaults config syntax, as you can see here with the changes made to the Bridgetown website, it very well can be a wholesale replacement.
Still needs documentation/tests.