Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Webpack parsing to Utils, enable for ERB templates #105

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

jaredcwhite
Copy link
Member

Hey @ParamagicDev, I relocated the bulk of the code that parses the manifest to the Utils module so we can use it from ERB/etc. as well. I also changed the behavior so it doesn't actually trigger any runtime errors and always lets the site build…I think there must have been a communication mixup before and I thought that's how it was already working. Anyway, if you could give this a quick looksee before merge, I'd appreciate it!

(Also fixed an issue with using Liquid filters from ERB…had to add duck-typing for a @context ivar so the filters could access the current site object).

@jaredcwhite jaredcwhite requested a review from KonnorRogers July 17, 2020 16:48
Copy link
Member

@KonnorRogers KonnorRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, no more unknown Liquid Exception (hopefully). I do like the idea of the parsing happening in a util. Also updated tests is always nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants