Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate Publisher class functionality to Resource::Base concern #403

Closed
jaredcwhite opened this issue Sep 30, 2021 · 3 comments · Fixed by #558
Closed

Relocate Publisher class functionality to Resource::Base concern #403

jaredcwhite opened this issue Sep 30, 2021 · 3 comments · Fixed by #558
Labels
process Improve the development process for the repo

Comments

@jaredcwhite
Copy link
Member

It seems like a stretch to have this as its own class…really could just be refactored down to one or two methods on site.
@jaredcwhite jaredcwhite added the process Improve the development process for the repo label Sep 30, 2021
@armahillo
Copy link

Publisher:
https://github.com/bridgetownrb/bridgetown/blob/main/bridgetown-core/lib/bridgetown-core/publisher.rb

Site
https://github.com/bridgetownrb/bridgetown/blob/main/bridgetown-core/lib/bridgetown-core/site.rb

@jaredcwhite
Copy link
Member Author

Actually…I believe this is only relevant to resources now, so it can just hang off of Resource::Base!

@jaredcwhite jaredcwhite reopened this May 20, 2022
@jaredcwhite
Copy link
Member Author

Seems like this wasn't fully completed after all, plus there's a missing gap of logic causing the bug of #557. Concerning this wasn't caught by the test suite. Will investigate!

@jaredcwhite jaredcwhite changed the title Relocate Publisher class functionality to Site concern Relocate Publisher class functionality to Resource::Base concern May 20, 2022
jaredcwhite added a commit that referenced this issue May 20, 2022
@jaredcwhite
Ensure future-dated resources import only when expected
9f62df9 
Fixes #403 #557
@jaredcwhite jaredcwhite mentioned this issue May 20, 2022
Merged
jaredcwhite added a commit that referenced this issue May 21, 2022
@jaredcwhite
Ensure future-dated resources import only when expected (#558)
00e0990 
Fixes #403 #557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process Improve the development process for the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure future-dated resources import only when expected bridgetownrb/bridgetown
2 participants
@armahillo @jaredcwhite