Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gha): Update setup-python version in GitHub Actions.md #5384

Closed
wants to merge 10 commits into from

Conversation

luis-giraldo
Copy link
Contributor

@luis-giraldo luis-giraldo commented Jul 28, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

We need to update the following action because not doing so will result on an error on certain architectures, see error below.

`Run actions/setup-python@v1
  with:
    python-version: 3.8
    architecture: x64
Error: Version 3.8 with arch x64 not found
Available versions: `

Version 4 of this action fixed the issue for me.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

achiar99 and others added 9 commits December 13, 2022 14:02
This reverts commit ced5447.
We need to update the following action because not doing so will result on an error on certain architectures, see error below.

`Run actions/setup-python@v1
  with:
    python-version: 3.8
    architecture: x64
Error: Version 3.8 with arch x64 not found
Available versions: `

Version 4 of this action fixed the issue for me
@luis-giraldo luis-giraldo changed the title Update setup-python GitHub Actions.md Fix: Update setup-python GitHub Actions.md Jul 28, 2023
@luis-giraldo luis-giraldo changed the title Fix: Update setup-python GitHub Actions.md Fix (gha): Update setup-python GitHub Actions.md Jul 28, 2023
@gruebel
Copy link
Contributor

gruebel commented Jul 29, 2023

hey @luis-giraldo thanks for the contribution, but your change doesn't fit with what you wrote.

@luis-giraldo
Copy link
Contributor Author

hey @gruebel thanks for the feedback, already fixed it on my last commit

@gruebel gruebel changed the title Fix (gha): Update setup-python GitHub Actions.md docs(gha): Update setup-python version in GitHub Actions.md Jul 31, 2023
@gruebel gruebel changed the base branch from master to main July 31, 2023 15:57
@gruebel
Copy link
Contributor

gruebel commented Jul 31, 2023

hey @luis-giraldo can you recreate your PR and create the merge against the main branch? You falsely set it to master. Changing it breaks the PR content.

@luis-giraldo
Copy link
Contributor Author

@gruebel sure, I'll close this PR and I'll open a new one. I'll also mention you on the new one

@luis-giraldo luis-giraldo deleted the patch-1 branch July 31, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants