Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): OCI Security Group Control Problem #3933

Merged
merged 2 commits into from
Dec 1, 2022
Merged

fix(terraform): OCI Security Group Control Problem #3933

merged 2 commits into from
Dec 1, 2022

Conversation

supu2
Copy link
Contributor

@supu2 supu2 commented Nov 24, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

AbsSecurtiGroupUnrestictedIngress is comparing "source_port_range" instead of "destination_port_range" which is not a true way to control access policy.

Fixes #3932

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@nimrodkor nimrodkor changed the base branch from master to main November 27, 2022 07:32
@nimrodkor
Copy link
Contributor

Thanks @supu2 !
Can you also fix the UTs please?

@supu2
Copy link
Contributor Author

supu2 commented Nov 27, 2022

Thanks @supu2 ! Can you also fix the UTs please?

Updated.

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution 🎄

@gruebel gruebel merged commit 33e7cb3 into bridgecrewio:main Dec 1, 2022
@supu2 supu2 deleted the oci/fix-security-group branch December 1, 2022 10:00
NoaAzoulay pushed a commit that referenced this pull request Dec 1, 2022
* Replace source_port_range to destination_port_range

* Replace source_port_range with destination_port_range

Co-authored-by: Guner UYGUN <[email protected]>
NoaAzoulay pushed a commit that referenced this pull request Dec 1, 2022
* Replace source_port_range to destination_port_range

* Replace source_port_range with destination_port_range

Co-authored-by: Guner UYGUN <[email protected]>
NoaAzoulay pushed a commit that referenced this pull request Dec 1, 2022
* Replace source_port_range to destination_port_range

* Replace source_port_range with destination_port_range

Co-authored-by: Guner UYGUN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI Security Group Control Problem
3 participants