feat(terraform): ACR container scanning

checkov/terraform/checks/resource/azure/ACRContainerScanEnabled.py

@@ -0,0 +1,33 @@
+from __future__ import annotations
+
+from typing import Any
+
+from checkov.common.models.enums import CheckResult, CheckCategories
+from checkov.terraform.checks.resource.base_resource_check import BaseResourceCheck
+
+
+class ACRContainerScanEnabled(BaseResourceCheck):
+    SKUS = {"Standard", "Premium"}  # noqa: CCE003  # a static attribute
+
+    def __init__(self):
+        name = "Enable vulnerability scanning for container images."
+        id = "CKV_AZURE_163"
+        supported_resources = ("azurerm_container_registry",)
+        categories = (CheckCategories.GENERAL_SECURITY,)
+        super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources)
+
+    def scan_resource_conf(self, conf: dict[str, list[Any]]) -> CheckResult:
+        # 'ContainerRegistry' tier
+        # 'standard', or higher -
+        # not Basic
+        if (
+            "sku" in conf.keys()
+            and isinstance(conf["sku"][0], str)
+            and conf["sku"][0] in ACRContainerScanEnabled.SKUS
+        ):
+            return CheckResult.PASSED
+
+        return CheckResult.FAILED
+
+
+check = ACRContainerScanEnabled()

tests/terraform/checks/resource/azure/example_ACRContainerScanEnabled/main.tf

@@ -0,0 +1,23 @@
+
+resource "azurerm_container_registry" "pass" {
+  name                   = "containerRegistry1"
+  resource_group_name    = azurerm_resource_group.rg.name
+  location               = azurerm_resource_group.rg.location
+  sku                    = "Premium"
+}
+
+
+resource "azurerm_container_registry" "pass2" {
+  name                = "containerRegistry1"
+  resource_group_name = azurerm_resource_group.rg.name
+  location            = azurerm_resource_group.rg.location
+  sku                 = "Standard"
+}
+
+
+resource "azurerm_container_registry" "fail" {
+  name                   = "containerRegistry1"
+  resource_group_name    = azurerm_resource_group.rg.name
+  location               = azurerm_resource_group.rg.location
+  sku                    = "Basic"
+}

tests/terraform/checks/resource/azure/test_ACRContainerScanEnabled.py

@@ -0,0 +1,42 @@
+import os
+import unittest
+
+from checkov.runner_filter import RunnerFilter
+from checkov.terraform.runner import Runner
+from checkov.terraform.checks.resource.azure.ACRContainerScanEnabled import check
+
+
+class TestACRContainerScanEnabled(unittest.TestCase):
+
+    def test(self):
+        runner = Runner()
+        current_dir = os.path.dirname(os.path.realpath(__file__))
+
+        test_files_dir = os.path.join(current_dir, "example_ACRContainerScanEnabled")
+        report = runner.run(root_folder=test_files_dir,
+                            runner_filter=RunnerFilter(checks=[check.id]))
+        summary = report.get_summary()
+
+        passing_resources = {
+            'azurerm_container_registry.pass',
+            'azurerm_container_registry.pass2',
+        }
+        failing_resources = {
+            'azurerm_container_registry.fail'
+        }
+        skipped_resources = {}
+
+        passed_check_resources = set([c.resource for c in report.passed_checks])
+        failed_check_resources = set([c.resource for c in report.failed_checks])
+
+        self.assertEqual(summary['passed'], len(passing_resources))
+        self.assertEqual(summary['failed'], len(failing_resources))
+        self.assertEqual(summary['skipped'], len(skipped_resources))
+        self.assertEqual(summary['parsing_errors'], 0)
+
+        self.assertEqual(passing_resources, passed_check_resources)
+        self.assertEqual(failing_resources, failed_check_resources)
+
+
+if __name__ == '__main__':
+    unittest.main()