Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): add CKV_AWS_282 to ensure that Redshift Serverless namespace is encrypted by KMS #3915

Merged
merged 1 commit into from
Nov 23, 2022
Merged

feat(terraform): add CKV_AWS_282 to ensure that Redshift Serverless namespace is encrypted by KMS #3915

merged 1 commit into from
Nov 23, 2022

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Nov 22, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added new policy

New/Edited policies

CKV_AWS_282 - checks that aws_redshiftserverless_namespace has a kms_key_id set

Description

We want to make sure that aws_redshiftserverless_namespace is encrypted.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156 bo156 changed the title Added CKV_AWS_282 check for setting inside terraform feat(terraform): add CKV_AWS_282 to ensure that Redshift Serverless namespace is encrypted by KMS Nov 22, 2022
gruebel
gruebel reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 🥇

checkov/terraform/checks/resource/aws/RedshiftServerlessNamespaceKMSKey.py Outdated Show resolved Hide resolved
checkov/terraform/checks/resource/aws/RedshiftServerlessNamespaceKMSKey.py Outdated Show resolved Hide resolved
checkov/terraform/checks/resource/aws/RedshiftServerlessNamespaceKMSKey.py Outdated Show resolved Hide resolved
@bo156 bo156 force-pushed the feature/CKV_AWS_282-redshiftsereverless_namespace_has_kms_key_id_set branch from 2a0a957 to cb51e5c Compare November 23, 2022 07:16
rotemavni
rotemavni approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@rotemavni rotemavni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

gruebel
gruebel approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@bo156 bo156 merged commit 14788d2 into master Nov 23, 2022
@bo156 bo156 deleted the feature/CKV_AWS_282-redshiftsereverless_namespace_has_kms_key_id_set branch November 23, 2022 09:38
mayblo pushed a commit to cider-rnd/checkov that referenced this pull request Nov 23, 2022
@bo156 @actions-user
feat(terraform): add CKV_AWS_282 to ensure that Redshift Serverless n…
8b35e7b 
…amespace is encrypted by KMS (bridgecrewio#3915)

Added CKV_AWS_282 check for setting  inside terraform
mayblo pushed a commit to cider-rnd/checkov that referenced this pull request Nov 23, 2022
@bo156 @actions-user
feat(terraform): add CKV_AWS_282 to ensure that Redshift Serverless n…
b13dd31 
…amespace is encrypted by KMS (bridgecrewio#3915)

Added CKV_AWS_282 check for setting  inside terraform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaaraVerner YaaraVerner YaaraVerner approved these changes

@rotemavni rotemavni rotemavni approved these changes

@achiar99 achiar99 achiar99 approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bo156 @gruebel @achiar99 @rotemavni @YaaraVerner