feat(secrets): Add Terraform multiline secrets handling #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marynaKK
reviewed
Nov 21, 2022
marynaKK
approved these changes
Nov 21, 2022
| return False | ||
|
|
||
|
|
||
| def ignore_secret( |
There was a problem hiding this comment.
If we add a mechanism for ignoring some data- maybe it can be added to a new file of single line parser (like there is a multiline parser)?
that's the same as skipping comments, but in this case, that's skipping specific blocks with data as a prefix.
There was a problem hiding this comment.
yeah, that was my problem, it is related to a specific file type, but I was not sure, if it is a good idea to add it to the multi parser, but I will revisit it 🤔
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Nov 22, 2022
…#3907) * add multiline secret support in Terraform * support jsonencode and heredoc and ignore data blocks * fix PR comments * create a dedicated single line parser class * add buildx step to build the image on self-hosted runners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
datablockFixes #1660
Checklist: