Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): add nested module address attribute #3904

Merged
merged 9 commits into from
Nov 21, 2022
Merged

feat(terraform): add nested module address attribute #3904

merged 9 commits into from
Nov 21, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Nov 20, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add __address__ attribute for blocks in tf graph based on inner modules

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@achiar99 achiar99 marked this pull request as draft November 20, 2022 09:42
@achiar99 achiar99 changed the title feature(terraform): implement nested module address feat(terraform): implement nested module address Nov 20, 2022
@achiar99 achiar99 changed the title feat(terraform): implement nested module address feat(terraform): add nested module address attribute Nov 20, 2022
@achiar99 achiar99 marked this pull request as ready for review November 20, 2022 10:33
YaaraVerner
YaaraVerner reviewed Nov 20, 2022
View reviewed changes
checkov/terraform/graph_builder/local_graph.py Outdated Show resolved Hide resolved
tests/terraform/graph/graph_builder/test_local_graph.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/local_graph.py Outdated Show resolved Hide resolved
@achiar99 achiar99 requested a review from YaaraVerner November 20, 2022 16:03
YaaraVerner
YaaraVerner approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@YaaraVerner YaaraVerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

ChanochShayner
ChanochShayner approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@achiar99 achiar99 merged commit 11ce479 into master Nov 21, 2022
@achiar99 achiar99 deleted the nested-module-address branch November 21, 2022 08:18
jneytchev-at-panw pushed a commit to jneytchev-at-panw/checkov that referenced this pull request Nov 21, 2022
@achiar99 @actions-user
feat(terraform): add nested module address attribute (bridgecrewio#3904)
603afac 
* implement nested module address

* add  test

* add  to all blocks types

* syn

* ??

* fix test

* move test

* fix logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaaraVerner YaaraVerner YaaraVerner approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achiar99 @ChanochShayner @YaaraVerner