Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): remove filter value validation #3896

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

kartikp10
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Removes validation of prisma metadata filter values since https://prisma.pan.dev/api/cloud/cspm/policy#operation/get-policy-filters-and-options only returns recently used values.

Fixes #3475

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kartikp10 kartikp10 marked this pull request as ready for review November 16, 2022 20:53
Copy link
Collaborator

@tsmithv11 tsmithv11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeurbanski1 mikeurbanski1 merged commit 6b66a5e into master Nov 16, 2022
@mikeurbanski1 mikeurbanski1 deleted the skip-filter-validation branch November 16, 2022 21:12
NandhiniC-PAN pushed a commit to NandhiniC-PAN/checkov that referenced this pull request Nov 17, 2022
* remove filter value validation

* fix test. fix typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prisma Policy Labels not working
3 participants