Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform(sca): added dependency tree format #3892

Merged
merged 3 commits into from
Nov 17, 2022
Merged

platform(sca): added dependency tree format #3892

merged 3 commits into from
Nov 17, 2022

Conversation

ayajbara
Copy link
Contributor

@ayajbara ayajbara commented Nov 16, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added dependency tree format for the results that created using dependency tree

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ayajbara ayajbara changed the title added dependencies to sca report platform(sca): added dependencies to sca packages report Nov 16, 2022
@ayajbara ayajbara marked this pull request as ready for review November 16, 2022 11:48
@ayajbara ayajbara changed the title platform(sca): added dependencies to sca packages report platform(sca): added dependency tree format to sca packages report Nov 16, 2022
@ayajbara ayajbara changed the title platform(sca): added dependency tree format to sca packages report platform(sca): added dependency tree format Nov 16, 2022
AdamDev
AdamDev reviewed Nov 16, 2022
View reviewed changes
checkov/common/sca/output.py Outdated Show resolved Hide resolved
checkov/common/sca/output.py Outdated Show resolved Hide resolved
gruebel
gruebel reviewed Nov 16, 2022
View reviewed changes
checkov/common/models/enums.py Outdated Show resolved Hide resolved
checkov/common/sca/output.py Outdated Show resolved Hide resolved
tests/sca_package/test_output.py Outdated Show resolved Hide resolved
gruebel
gruebel approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@ayajbara ayajbara merged commit 08e1573 into master Nov 17, 2022
@ayajbara ayajbara deleted the add_dependencies_sca_pkgs branch November 17, 2022 14:41
mikeurbanski1 pushed a commit that referenced this pull request Nov 17, 2022
@ayajbara @actions-user
platform(sca): added dependency tree format (#3892)
20c0def 
* added dependencies to sca report

* fixed

* changed format names
mikeurbanski1 pushed a commit that referenced this pull request Nov 17, 2022
@ayajbara @actions-user
platform(sca): added dependency tree format (#3892)
345b8a1 
* added dependencies to sca report

* fixed

* changed format names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@AdamDev AdamDev AdamDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayajbara @AdamDev @gruebel