Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): remove env var for running contributor metrics report and add logs #3873

Merged
merged 1 commit into from
Nov 14, 2022
Merged

feat(general): remove env var for running contributor metrics report and add logs #3873

merged 1 commit into from
Nov 14, 2022

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Nov 14, 2022

This PR removes env var protection from running contributor metrics report and adds debug logs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel changed the title feat(general) - remove env var for running contributor metrics report and add logs feat(general): remove env var for running contributor metrics report and add logs Nov 14, 2022
@maxamel maxamel marked this pull request as ready for review November 14, 2022 09:47
@maxamel maxamel merged commit ccd70db into master Nov 14, 2022
@maxamel maxamel deleted the remove-contributor-metrics-flag branch November 14, 2022 09:54
nikolaik pushed a commit to nikolaik/checkov that referenced this pull request Nov 14, 2022
@maxamel
feat(general): remove env var for running contributor metrics report …
be9ba97 
…and add logs (bridgecrewio#3873)

remove env var for running contributor metrics report and add logs

Co-authored-by: Max Amelchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marynaKK marynaKK marynaKK approved these changes

@Eliran-Turgeman Eliran-Turgeman Eliran-Turgeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxamel @Eliran-Turgeman @marynaKK