platform(sca): Fix bom report #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2022 17:34
AdamDev
changed the title
ayajbara
reviewed
Nov 14, 2022
gruebel
reviewed
Nov 14, 2022
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
ayajbara
approved these changes
Nov 14, 2022
added 2 commits
November 14, 2022 16:29
ayajbara
pushed a commit
that referenced
this pull request
Nov 15, 2022
* fix bom report * bug fixes * fix testing * fix csv * clean * clean * clean * fix lint and testing * fix tests * fix lint * make test support new case * add logs * Update checkov/common/output/common.py Co-authored-by: Anton Grübel <[email protected]> * Update checkov/common/output/common.py Co-authored-by: Anton Grübel <[email protected]> * fix pr comments * Update checkov/common/output/csv.py Co-authored-by: Anton Grübel <[email protected]> * move unknown string to const * Update checkov/common/output/csv.py Co-authored-by: Anton Grübel <[email protected]> * fix lint * add tests * prettifier test Co-authored-by: Adam Varsano <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
ayajbara
pushed a commit
that referenced
this pull request
Nov 15, 2022
* fix bom report * bug fixes * fix testing * fix csv * clean * clean * clean * fix lint and testing * fix tests * fix lint * make test support new case * add logs * Update checkov/common/output/common.py Co-authored-by: Anton Grübel <[email protected]> * Update checkov/common/output/common.py Co-authored-by: Anton Grübel <[email protected]> * fix pr comments * Update checkov/common/output/csv.py Co-authored-by: Anton Grübel <[email protected]> * move unknown string to const * Update checkov/common/output/csv.py Co-authored-by: Anton Grübel <[email protected]> * fix lint * add tests * prettifier test Co-authored-by: Adam Varsano <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
On creating the BOM report, the delimiter was a comma character, it cause an issue because there are some licenses that contain comma characters.
Fixes # (issue)
Instead of encode and decode the licenses to string, just pass them as a list.
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: