Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): NSGRulePortAccessRestricted - Remove the condition for dynamic blocks #3862

Merged

Conversation

ChanochShayner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

From this PR - Here we are skipping the check for resources with dynamic blocks, now with the support of dynamic blocks, we can remove the condition.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner merged commit 9052caa into master Nov 13, 2022
@ChanochShayner ChanochShayner deleted the support-dynamic-blocks-in-NSGRulePortAccessRestricted branch November 13, 2022 07:47
Guo-Bicheng pushed a commit to Guo-Bicheng/checkov that referenced this pull request Nov 14, 2022
…or dynamic blocks (bridgecrewio#3862)

Remove the condition for dynamic blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants