-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): add CKV NCP rules about ncloud access control group rule #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pj991207
changed the title
eat(terraform): add CKV NCP rules about ncloud access control group rule
feat(terraform): add CKV NCP rules about ncloud access control group rule
Nov 12, 2022
nimrodkor
approved these changes
Nov 27, 2022
gruebel
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, added to small comments
checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml
Outdated
Show resolved
Hide resolved
…leDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]>
…leDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]>
gruebel
approved these changes
Dec 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Dec 4, 2022
…rule (bridgecrewio#3860) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.08][delete]CKVP_NCP_15 * [22.11.08][add]CKV_NCP_37 * [22.11.11][fix]CKV_NCP_37->26 * Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Dec 4, 2022
…rule (bridgecrewio#3860) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.08][delete]CKVP_NCP_15 * [22.11.08][add]CKV_NCP_37 * [22.11.11][fix]CKV_NCP_37->26 * Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Dec 4, 2022
…rule (bridgecrewio#3860) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.08][delete]CKVP_NCP_15 * [22.11.08][add]CKV_NCP_37 * [22.11.11][fix]CKV_NCP_37->26 * Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml okay Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_26 is associated with access control group has access control group rule
Description
https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/lb_listener
Checklist: