Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add CKV NCP rules about ncloud access control group rule #3860

Merged
merged 12 commits into from
Dec 4, 2022

Conversation

pj991207
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_26 is associated with access control group has access control group rule

Description

https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/lb_listener

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pj991207 pj991207 changed the title eat(terraform): add CKV NCP rules about ncloud access control group rule feat(terraform): add CKV NCP rules about ncloud access control group rule Nov 12, 2022
@nimrodkor nimrodkor changed the base branch from master to main November 27, 2022 07:47
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, added to small comments

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@gruebel gruebel merged commit 2367920 into bridgecrewio:main Dec 4, 2022
gruebel added a commit to gruebel/checkov that referenced this pull request Dec 4, 2022
…rule (bridgecrewio#3860)

* [22.10.27][add]LBListenerUsesSecureProtocols

* [22.11.05][add]NCP_LBTargetGroupUsingHTTPS

* [22.11.05][delete]ncp_13_rule

* [22.11.08][delete]CKVP_NCP_15

* [22.11.08][add]CKV_NCP_37

* [22.11.11][fix]CKV_NCP_37->26

* Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml

okay

Co-authored-by: Anton Grübel <[email protected]>

* Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml

okay

Co-authored-by: Anton Grübel <[email protected]>

Co-authored-by: Kuemjong Jeong <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
gruebel added a commit to gruebel/checkov that referenced this pull request Dec 4, 2022
…rule (bridgecrewio#3860)

* [22.10.27][add]LBListenerUsesSecureProtocols

* [22.11.05][add]NCP_LBTargetGroupUsingHTTPS

* [22.11.05][delete]ncp_13_rule

* [22.11.08][delete]CKVP_NCP_15

* [22.11.08][add]CKV_NCP_37

* [22.11.11][fix]CKV_NCP_37->26

* Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml

okay

Co-authored-by: Anton Grübel <[email protected]>

* Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml

okay

Co-authored-by: Anton Grübel <[email protected]>

Co-authored-by: Kuemjong Jeong <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
gruebel added a commit to gruebel/checkov that referenced this pull request Dec 4, 2022
…rule (bridgecrewio#3860)

* [22.10.27][add]LBListenerUsesSecureProtocols

* [22.11.05][add]NCP_LBTargetGroupUsingHTTPS

* [22.11.05][delete]ncp_13_rule

* [22.11.08][delete]CKVP_NCP_15

* [22.11.08][add]CKV_NCP_37

* [22.11.11][fix]CKV_NCP_37->26

* Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml

okay

Co-authored-by: Anton Grübel <[email protected]>

* Update checkov/terraform/checks/graph_checks/ncp/AccessControlGroupRuleDefine.yaml

okay

Co-authored-by: Anton Grübel <[email protected]>

Co-authored-by: Kuemjong Jeong <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants