Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): add CKV NCP rules about Load Balancer Listener Using HTTPS #3858

Merged
merged 31 commits into from
Nov 29, 2022
Merged

feat(terraform): add CKV NCP rules about Load Balancer Listener Using HTTPS #3858

merged 31 commits into from
Nov 29, 2022

Conversation

pj991207
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_24 is associated with Load Balancer Listener Using HTTPS

Description

https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/lb_listener

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pj991207 and others added 26 commits October 27, 2022 18:12
@pj991207
[22.10.27][add]LBListenerUsesSecureProtocols
6b5d88a
@Floodnut
Merge branch 'bridgecrewio:master' into master
bc86ad9
@pj991207
Merge branch 'bridgecrewio:master' into master
1a03f18
@pj991207
[22.11.05][add]NCP_LBTargetGroupUsingHTTPS
77b362b
@pj991207
[22.11.05][delete]ncp_13_rule
5952dd8
@pj991207
Merge branch 'bridgecrewio:master' into master
7ad9795
@pj991207 @gruebel
Update checkov/terraform/checks/resource/ncp/LBTargetGroupUsingHTTPS.py
7a416e8 
Co-authored-by: Anton Grübel <[email protected]>
@pj991207 @gruebel
Update checkov/terraform/checks/resource/ncp/LBTargetGroupUsingHTTPS.py
cc64169 
Co-authored-by: Anton Grübel <[email protected]>
@pj991207
[22.11.08][delete]CKVP_NCP_15
218ebab
@pj991207
[22.11.08]CKV_NCP_32
c3aa017
@pj991207
Revert "[22.11.08]CKV_NCP_32"
f9be912 
This reverts commit c3aa017.
@pj991207
[22.11.08][add]CKV_NCP_32
b7341f7
@pj991207
Revert "[22.11.08][add]CKV_NCP_32"
b92c23b 
This reverts commit b7341f7.
@Floodnut
Merge branch 'bridgecrewio:master' into master
e840d67
@pj991207
Merge branch 'master' of https://github.com/init-cloud/checkov
54e6d81
@Floodnut
Merge branch 'bridgecrewio:master' into master
51e7f0c
@pj991207
[22.11.11[[add]CKV2_AWS_42
8837631
@pj991207
Merge branch 'ncp/rule-15' of https://github.com/init-cloud/checkov i…
4275cac 
…nto ncp/rule-15
@pj991207
[22.11.12][fix]CKV_NCP_15
e773947
@pj991207
Revert "[22.11.12][fix]CKV_NCP_15"
f0a7a74 
This reverts commit e773947.
@pj991207
Merge branch 'bridgecrewio:master' into master
a8d41e3
@pj991207
Merge branch 'master' of https://github.com/init-cloud/checkov into n…
30e09d4 
…cp/rule-29
@pj991207
[22.11.12][fix]CKV2_AWS_42
17f1a26
@pj991207
[22.11.12][add]CKV_NCP_30
74c076b
@pj991207
[22.11.12][fix]CKV_NCP_24
c56863c
@pj991207
[22.11.12][fix]CKV_NCP_24
0b62bdc
@nimrodkor nimrodkor changed the base branch from master to main November 27, 2022 07:47
gruebel
gruebel approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

nimrodkor
nimrodkor approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@nimrodkor nimrodkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 final suggestion @pj991207

pj991207 and others added 3 commits November 29, 2022 01:00
@pj991207
Update checkov/terraform/checks/resource/ncp/LBListenerUsingHTTPS.py
4a52f4b 
Co-authored-by: Nimrod Kor <[email protected]>
@pj991207
[22.11.29][fix]CKV_NCP_24
db7a2e5 
when I fixed the code ( ['HTTPS'] => 'HTTPS') the test fail..
@pj991207
[22.11.29][fix]CKV_NCP_24
8432a66 
fix code 'HTTPS'
@nimrodkor nimrodkor merged commit c0fc1c2 into bridgecrewio:main Nov 29, 2022
pj991207 added a commit to init-cloud/checkov that referenced this pull request Nov 30, 2022
@pj991207 @Floodnut
@gruebel @actions-user
feat(terraform): add CKV NCP rules about Load Balancer Listener Using…
ed1ea80 
… HTTPS (bridgecrewio#3858)

* [22.10.27][add]LBListenerUsesSecureProtocols

* [22.11.05][add]NCP_LBTargetGroupUsingHTTPS

* [22.11.05][delete]ncp_13_rule

* Update checkov/terraform/checks/resource/ncp/LBTargetGroupUsingHTTPS.py

Co-authored-by: Anton Grübel <[email protected]>

* Update checkov/terraform/checks/resource/ncp/LBTargetGroupUsingHTTPS.py

Co-authored-by: Anton Grübel <[email protected]>

* [22.11.08][delete]CKVP_NCP_15

* [22.11.08]CKV_NCP_32

* Revert "[22.11.08]CKV_NCP_32"

This reverts commit c3aa017.

* [22.11.08][add]CKV_NCP_32

* Revert "[22.11.08][add]CKV_NCP_32"

This reverts commit b7341f7.

* [22.11.11[[add]CKV2_AWS_42

* [22.11.12][fix]CKV_NCP_15

* Revert "[22.11.12][fix]CKV_NCP_15"

This reverts commit e773947.

* [22.11.12][fix]CKV2_AWS_42

* [22.11.12][add]CKV_NCP_30

* [22.11.12][fix]CKV_NCP_24

* [22.11.12][fix]CKV_NCP_24

* [22.11.28][fix]CKV_NCP_24

* Update checkov/terraform/checks/resource/ncp/LBListenerUsingHTTPS.py

Co-authored-by: Nimrod Kor <[email protected]>

* [22.11.29][fix]CKV_NCP_24

when I fixed the code ( ['HTTPS'] => 'HTTPS') the test fail..

* [22.11.29][fix]CKV_NCP_24

fix code 'HTTPS'

Co-authored-by: Kuemjong Jeong <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Nimrod Kor <[email protected]>
pj991207 added a commit to init-cloud/checkov that referenced this pull request Nov 30, 2022
@pj991207 @Floodnut
@gruebel @actions-user
feat(terraform): add CKV NCP rules about Load Balancer Listener Using…
b3606cc 
… HTTPS (bridgecrewio#3858)

* [22.10.27][add]LBListenerUsesSecureProtocols

* [22.11.05][add]NCP_LBTargetGroupUsingHTTPS

* [22.11.05][delete]ncp_13_rule

* Update checkov/terraform/checks/resource/ncp/LBTargetGroupUsingHTTPS.py

Co-authored-by: Anton Grübel <[email protected]>

* Update checkov/terraform/checks/resource/ncp/LBTargetGroupUsingHTTPS.py

Co-authored-by: Anton Grübel <[email protected]>

* [22.11.08][delete]CKVP_NCP_15

* [22.11.08]CKV_NCP_32

* Revert "[22.11.08]CKV_NCP_32"

This reverts commit c3aa017.

* [22.11.08][add]CKV_NCP_32

* Revert "[22.11.08][add]CKV_NCP_32"

This reverts commit b7341f7.

* [22.11.11[[add]CKV2_AWS_42

* [22.11.12][fix]CKV_NCP_15

* Revert "[22.11.12][fix]CKV_NCP_15"

This reverts commit e773947.

* [22.11.12][fix]CKV2_AWS_42

* [22.11.12][add]CKV_NCP_30

* [22.11.12][fix]CKV_NCP_24

* [22.11.12][fix]CKV_NCP_24

* [22.11.28][fix]CKV_NCP_24

* Update checkov/terraform/checks/resource/ncp/LBListenerUsingHTTPS.py

Co-authored-by: Nimrod Kor <[email protected]>

* [22.11.29][fix]CKV_NCP_24

when I fixed the code ( ['HTTPS'] => 'HTTPS') the test fail..

* [22.11.29][fix]CKV_NCP_24

fix code 'HTTPS'

Co-authored-by: Kuemjong Jeong <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Nimrod Kor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@nimrodkor nimrodkor nimrodkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pj991207 @Floodnut @nimrodkor @gruebel