feat(terraform): add CKV NCP rules about server instance and public IP #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrodkor
approved these changes
Nov 27, 2022
gruebel
reviewed
Nov 28, 2022
BaseResourceCheck -> BaseResourceNegativeValueCheck
pj991207
added a commit
to init-cloud/checkov
that referenced
this pull request
Nov 30, 2022
bridgecrewio#3857) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * [22.11.10 ][add]CKV_NCP_23 * [22.11.29][fix]CKV_NCP_23 BaseResourceCheck -> BaseResourceNegativeValueCheck Co-authored-by: Kuemjong Jeong <[email protected]>
pj991207
added a commit
to init-cloud/checkov
that referenced
this pull request
Nov 30, 2022
bridgecrewio#3857) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * [22.11.10 ][add]CKV_NCP_23 * [22.11.29][fix]CKV_NCP_23 BaseResourceCheck -> BaseResourceNegativeValueCheck Co-authored-by: Kuemjong Jeong <[email protected]>
pj991207
added a commit
to init-cloud/checkov
that referenced
this pull request
Nov 30, 2022
bridgecrewio#3857) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * [22.11.10 ][add]CKV_NCP_23 * [22.11.29][fix]CKV_NCP_23 BaseResourceCheck -> BaseResourceNegativeValueCheck Co-authored-by: Kuemjong Jeong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_23 is associated with "ncloud server instance should not have Public IP"
Description
https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/public_ip
Checklist: