fix(terraform): Handled nested unrendered vars #3853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Adds logic to handle unrendered variables for custom policies that use nested attributes, like checking for a specific tag.
Previously,
tags.component equals ...
fortags = local.unrendered_var
would fail because the value of that attribute isNone
, and this doesn't get picked up as an unrendered var. The fix is to check each attribute part (firsttags
, thentags.component
) to see if it maps to an unrendered var.Additionally, , a policy like
tags.component exists
would fail fortags = local.unrendered_var
, because of theis_value_attribute_check
condition. This PR modifies that behavior to only care aboutis_value_attribute_check
when we are evaluating the literal attribute in the policy (tags.component
, not justtags
).This PR also adds some explicit tests for simple and nested unrendered variables for conditions with and without
value
, since it seemed like those were missing. (They are just reflected in changed results of other tests for other things).Checklist: