Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): fix an issue with dynamics replacing a whole block #3846

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Nov 11, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • if a whole block is replaced then it doesn't it is not enclosed in a list, which results in errors downstream

Fixes #3845

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@Eliran-Turgeman Eliran-Turgeman merged commit 22a2bd0 into bridgecrewio:master Nov 11, 2022
@gruebel gruebel deleted the fix-dynamic-issue branch November 11, 2022 13:04
pj991207 pushed a commit to init-cloud/checkov that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkov action fails for certain modules due to what seems like datatype issue
3 participants