Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bicep): make ARM AKS checks compatible with Bicep #3836

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Nov 9, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • added apiVersion to config, if it is a Bicep resource to improve compatibility with ARM checks
  • improved AKS checks to support Bicep resources

Fixes #3805

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sbe-arg
Copy link

sbe-arg commented Nov 10, 2022

Looking promising thanks for doing this @gruebel

@gruebel gruebel merged commit 594a4e7 into bridgecrewio:master Nov 10, 2022
@gruebel gruebel deleted the adjust-arm-checks branch November 10, 2022 10:21
JamesWoolfenden pushed a commit that referenced this pull request Nov 10, 2022
* make ARM AKS checks compatible with Bicep

* fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure AKS managed clusters RBAC - CKV_AZURE_5
4 participants