feat(terraform): add CKV NCP rules about NKSPublicAccess #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrodkor
approved these changes
Nov 13, 2022
gruebel
reviewed
Nov 13, 2022
tests/terraform/checks/resource/ncp/example_NksPublicAccess/main.tf
Outdated
Show resolved
Hide resolved
gruebel
reviewed
Nov 14, 2022
| from checkov.terraform.checks.resource.base_resource_check import BaseResourceCheck | ||
|
|
||
|
|
||
| class NKSPublicAccess(BaseResourceCheck): |
There was a problem hiding this comment.
you actually want to use negative resource value check here. Here is an example of how it looks like https://github.com/bridgecrewio/checkov/blob/master/checkov/terraform/checks/resource/aws/DMSReplicationInstancePubliclyAccessible.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_19 is associated with NKSPublicAccess
Description
https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/nks_cluster
Checklist: