feat(terraform): add CKV NCP rules about Load Balancer Exposed to Internet #3819

pj991207 · 2022-11-08T05:58:29Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_16 is associated with Load Balancer Exposed to Internet

Description

https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/lb

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my feature, policy, or fix is effective and works
New and existing tests pass locally with my changes

[22.11.08][delete]NCP_CKV_15

…HTTPS directory [22.11.08][delete]CKV_NCP_15

[22.11.08][delete]CVK_NCP_15

…nto ncp/rule-16

This reverts commit c3aa017.

This reverts commit b7341f7.

gruebel

nice work, just two minor things

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

[22.11.10][fix]CKV_NCP_16 Co-authored-by: Anton Grübel <[email protected]>

gruebel

🍻

ChanochShayner

👑

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

This reverts commit 25d3a6e.

nimrodkor · 2022-11-13T08:30:37Z

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

+    def get_expected_values(self) -> List[Any]:
+        return ["PRIVATE"]


Suggested change

def get_expected_values(self) -> List[Any]:

return ["PRIVATE"]

def get_expected_value(self) -> Any:

return "PRIVATE"

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

Co-authored-by: Anton Grübel <[email protected]>

…ernet (bridgecrewio#3819) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.06][addNCP_LBNetworkPrivate * Delete LBTargetGroupUsingHTTPS.py [22.11.08][delete]NCP_CKV_15 * Delete tests/terraform/checks/resource/ncp/example_LBTargetGroupUsingHTTPS directory [22.11.08][delete]CKV_NCP_15 * Delete test_LBTargetGroupUsingHTTPS.py [22.11.08][delete]CVK_NCP_15 * [22.11.08][add]ncp_ckv_16 example tf code * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py [22.11.10][fix]CKV_NCP_16 Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py [22.11.10][fix]CKV_NCP_16 Co-authored-by: Anton Grübel <[email protected]> * Revert "[22.11.12][fix]NCP_CKV_16" This reverts commit 25d3a6e. * [22.11.12][fix]CKV_NCP_16 * [22.11.12][fix]CKV_NCP_16 * [22.11.13][fix]CKV_NCP_16 * Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>

pj991207 and others added 19 commits October 27, 2022 18:12

[22.10.27][add]LBListenerUsesSecureProtocols

6b5d88a

Merge branch 'bridgecrewio:master' into master

bc86ad9

Merge branch 'bridgecrewio:master' into master

1a03f18

[22.11.05][add]NCP_LBTargetGroupUsingHTTPS

77b362b

[22.11.05][delete]ncp_13_rule

5952dd8

Merge branch 'bridgecrewio:master' into master

7ad9795

[22.11.06][addNCP_LBNetworkPrivate

e7ffe7d

Merge branch 'bridgecrewio:master' into ncp/rule-16

20caece

Delete LBTargetGroupUsingHTTPS.py

255ac39

[22.11.08][delete]NCP_CKV_15

Delete tests/terraform/checks/resource/ncp/example_LBTargetGroupUsing…

750f155

…HTTPS directory [22.11.08][delete]CKV_NCP_15

Delete test_LBTargetGroupUsingHTTPS.py

8c1fb91

[22.11.08][delete]CVK_NCP_15

[22.11.08][add]ncp_ckv_16 example tf code

cd3a124

Merge branch 'ncp/rule-16' of https://github.com/init-cloud/checkov i…

8f915a9

…nto ncp/rule-16

[22.11.08][delete]CKVP_NCP_15

218ebab

[22.11.08]CKV_NCP_32

c3aa017

Revert "[22.11.08]CKV_NCP_32"

f9be912

This reverts commit c3aa017.

[22.11.08][add]CKV_NCP_32

b7341f7

Revert "[22.11.08][add]CKV_NCP_32"

b92c23b

This reverts commit b7341f7.

Merge branch 'bridgecrewio:master' into master

e840d67

gruebel reviewed Nov 9, 2022

View reviewed changes

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Outdated Show resolved Hide resolved

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Outdated Show resolved Hide resolved

pj991207 and others added 3 commits November 10, 2022 15:30

Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

798c698

[22.11.10][fix]CKV_NCP_16 Co-authored-by: Anton Grübel <[email protected]>

Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

66f424b

[22.11.10][fix]CKV_NCP_16 Co-authored-by: Anton Grübel <[email protected]>

Merge branch 'master' of https://github.com/init-cloud/checkov

54e6d81

gruebel approved these changes Nov 10, 2022

View reviewed changes

marynaKK approved these changes Nov 10, 2022

View reviewed changes

ChanochShayner approved these changes Nov 10, 2022

View reviewed changes

nimrodkor reviewed Nov 10, 2022

View reviewed changes

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Outdated Show resolved Hide resolved

Floodnut and others added 3 commits November 11, 2022 20:53

Merge branch 'bridgecrewio:master' into master

51e7f0c

Merge branch 'bridgecrewio:master' into master

a8d41e3

Merge branch 'master' of https://github.com/init-cloud/checkov

d250948

pj991207 added 3 commits November 12, 2022 10:07

[22.11.12][fix]NCP_CKV_16

25d3a6e

Revert "[22.11.12][fix]NCP_CKV_16"

ec25900

This reverts commit 25d3a6e.

[22.11.12][fix]CKV_NCP_16

74715cb

pj991207 force-pushed the ncp/rule-16 branch from 072e6d5 to 74715cb Compare November 12, 2022 01:17

[22.11.12][fix]CKV_NCP_16

2e814c2

nimrodkor reviewed Nov 13, 2022

View reviewed changes

[22.11.13][fix]CKV_NCP_16

5cda816

gruebel reviewed Nov 13, 2022

View reviewed changes

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Outdated Show resolved Hide resolved

checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py Outdated Show resolved Hide resolved

pj991207 and others added 2 commits November 14, 2022 12:24

Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

c0062a3

Co-authored-by: Anton Grübel <[email protected]>

Update checkov/terraform/checks/resource/ncp/LBNetworkPrivate.py

105467d

Co-authored-by: Anton Grübel <[email protected]>

gruebel merged commit 17c72d5 into bridgecrewio:master Nov 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(terraform): add CKV NCP rules about Load Balancer Exposed to Internet #3819

feat(terraform): add CKV NCP rules about Load Balancer Exposed to Internet #3819

pj991207 commented Nov 8, 2022

gruebel left a comment

gruebel left a comment

ChanochShayner left a comment

nimrodkor Nov 13, 2022

pj991207 Nov 14, 2022

		def get_expected_values(self) -> List[Any]:
		return ["PRIVATE"]

feat(terraform): add CKV NCP rules about Load Balancer Exposed to Internet #3819

feat(terraform): add CKV NCP rules about Load Balancer Exposed to Internet #3819

Conversation

pj991207 commented Nov 8, 2022

Description

Description

Checklist:

gruebel left a comment

Choose a reason for hiding this comment

gruebel left a comment

Choose a reason for hiding this comment

ChanochShayner left a comment

Choose a reason for hiding this comment

nimrodkor Nov 13, 2022

Choose a reason for hiding this comment

pj991207 Nov 14, 2022

Choose a reason for hiding this comment