Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Add Env Var for rendering Dynamic Blocks #3816

Merged
merged 5 commits into from
Nov 8, 2022
Merged

feat(terraform): Add Env Var for rendering Dynamic Blocks #3816

merged 5 commits into from
Nov 8, 2022

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Nov 7, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add Env Var for rendering Dynamic Modules

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner changed the title feat(terraform): Add Env Var for rendering Dynamic Modules feat(terraform): Add Env Var for rendering Dynamic Blocks Nov 7, 2022
@ChanochShayner ChanochShayner merged commit b71749b into master Nov 8, 2022
@ChanochShayner ChanochShayner deleted the dynamic-modules-env-var branch November 8, 2022 09:04
maxamel pushed a commit that referenced this pull request Nov 8, 2022
@ChanochShayner @gruebel @schosterbarak
feat(terraform): Add Env Var for rendering Dynamic Blocks (#3816)
f93c3ca 
* Add Env Var for rendering Dynamic Modules

* CR fix

* Update checkov/terraform/graph_builder/graph_components/module.py

Co-authored-by: Anton Grübel <[email protected]>

* CR fix

Co-authored-by: Anton Grübel <[email protected]>
maxamel pushed a commit that referenced this pull request Nov 8, 2022
@ChanochShayner @gruebel
feat(terraform): Add Env Var for rendering Dynamic Blocks (#3816)
79ba526 
* Add Env Var for rendering Dynamic Modules

* CR fix

* Update checkov/terraform/graph_builder/graph_components/module.py

Co-authored-by: Anton Grübel <[email protected]>

* CR fix

Co-authored-by: Anton Grübel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanochShayner @tronxd @gruebel