Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Support for nested dynamic modules #3813

Merged
merged 10 commits into from
Nov 9, 2022
Merged

feat(terraform): Support for nested dynamic modules #3813

merged 10 commits into from
Nov 9, 2022

Conversation

ChanochShayner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adding support for nested dynamic block rendering.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🍻

checkov/terraform/graph_builder/utils.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/variable_rendering/renderer.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/variable_rendering/renderer.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/variable_rendering/renderer.py Outdated Show resolved Hide resolved
tests/terraform/graph/variable_rendering/test_resources/dynamic_blocks_with_nested/main.tf Show resolved Hide resolved
gruebel
gruebel approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕

@gruebel gruebel merged commit c93f433 into master Nov 9, 2022
@gruebel gruebel deleted the dynamic_modules_with_nested_map_objects branch November 9, 2022 07:12
gruebel pushed a commit to gruebel/checkov that referenced this pull request Nov 9, 2022
@ChanochShayner @tronxd @schosterbarak
feat(terraform): Support for nested dynamic modules (bridgecrewio#3813)
aa83638 
* Support for nested dynamic modules

* Fix condition

* Avoid update dup dynamic changed attributes

* flake8 fix

* CR Fixes

* support nested dynamic blocks breadcrumbs

* Mock CHECKOV_RENDER_DYNAMIC_MODULES env var

* Checks if value exist in map, add try for StopIteration

Co-authored-by: tronxd <[email protected]>
@ChanochShayner ChanochShayner self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronxd tronxd tronxd left review comments

@rotemavni rotemavni rotemavni approved these changes

@gruebel gruebel gruebel approved these changes

Assignees

@ChanochShayner ChanochShayner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChanochShayner @tronxd @gruebel @rotemavni