Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): Added Number of Words operator #3801

Merged
merged 9 commits into from
Nov 8, 2022

Conversation

kadoshms
Copy link
Contributor

@kadoshms kadoshms commented Nov 6, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added support for two operators:

number_of_words_equals and number_of_words_not_equals that given a string value, counts the number of words in it.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kadoshms kadoshms changed the title feat(solvers): Added Number of Words operator feat(general): Added Number of Words operator Nov 6, 2022
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 🍺 just one suggestion, but an important one 😄

@kadoshms kadoshms requested a review from gruebel November 7, 2022 11:37
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 🍻

@gruebel gruebel merged commit 7765ed4 into master Nov 8, 2022
@gruebel gruebel deleted the number-of-words-operator branch November 8, 2022 14:05
kadoshms added a commit that referenced this pull request Nov 8, 2022
* feat: add support for number_of_words_equals and number_of_words_not_equals attribute solvers

* fix: fixed solver type issue

* fix: using split() instead of split(" ") to handle multiple whitespaces as well

* chore: renamed the attribute solver file names

Co-authored-by: Mor Kadosh <[email protected]>
kadoshms added a commit that referenced this pull request Nov 8, 2022
* feat: add support for number_of_words_equals and number_of_words_not_equals attribute solvers

* fix: fixed solver type issue

* fix: using split() instead of split(" ") to handle multiple whitespaces as well

* chore: renamed the attribute solver file names

Co-authored-by: Mor Kadosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants