-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): Added Number of Words operator #3801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equals attribute solvers
kadoshms
changed the title
feat(solvers): Added Number of Words operator
feat(general): Added Number of Words operator
Nov 6, 2022
gruebel
reviewed
Nov 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job 🍺 just one suggestion, but an important one 😄
checkov/common/checks_infra/solvers/attribute_solvers/number_of_words_equals_solver.py
Outdated
Show resolved
Hide resolved
gruebel
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice 🍻
ChanochShayner
approved these changes
Nov 8, 2022
kadoshms
added a commit
that referenced
this pull request
Nov 8, 2022
* feat: add support for number_of_words_equals and number_of_words_not_equals attribute solvers * fix: fixed solver type issue * fix: using split() instead of split(" ") to handle multiple whitespaces as well * chore: renamed the attribute solver file names Co-authored-by: Mor Kadosh <[email protected]>
kadoshms
added a commit
that referenced
this pull request
Nov 8, 2022
* feat: add support for number_of_words_equals and number_of_words_not_equals attribute solvers * fix: fixed solver type issue * fix: using split() instead of split(" ") to handle multiple whitespaces as well * chore: renamed the attribute solver file names Co-authored-by: Mor Kadosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added support for two operators:
number_of_words_equals
andnumber_of_words_not_equals
that given a string value, counts the number of words in it.Checklist: