Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Dynamic Modules Support map type #3800

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Nov 6, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added support for dynamic modules from map variables, for example:
(Full example in the tests folder)

dynamic "ingress" {
    for_each = var.http_headers
    content {
      rule_no    = ingress.value.num  # or ["num"]
      protocol   = ingress.value.protoc  # or ["protoc"]
      action     = "allow"
      cidr_block = ingress.value.values  # or ["values"]
      from_port  = 22
      to_port    = 22
    }
  }

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@tronxd tronxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had some comments

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🍺 , added some comments

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@ChanochShayner ChanochShayner merged commit 7089ca4 into master Nov 7, 2022
@ChanochShayner ChanochShayner deleted the dynamic_modules_with_map_objects branch November 7, 2022 12:11
ayajbara pushed a commit that referenced this pull request Nov 7, 2022
* Support for Dynamic moduls map type

* Fix UTs

* Fix UTs

* CR fixes

* CR fixes
ayajbara pushed a commit that referenced this pull request Nov 7, 2022
* Support for Dynamic moduls map type

* Fix UTs

* Fix UTs

* CR fixes

* CR fixes
@ChanochShayner ChanochShayner self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants