-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Dynamic Modules Support map type #3800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, had some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🍺 , added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍪
* Support for Dynamic moduls map type * Fix UTs * Fix UTs * CR fixes * CR fixes
* Support for Dynamic moduls map type * Fix UTs * Fix UTs * CR fixes * CR fixes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added support for dynamic modules from map variables, for example:
(Full example in the tests folder)
Checklist: