-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure): Add get resource names for azure_pipelines #3798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
Had one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @arielkru !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🍸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍹
|
||
def _get_resource_from_code_block(block_to_inspect: dict[str, Any], inspected_key: str | None) -> str | None: | ||
if block_to_inspect[START_LINE] <= start_line <= end_line <= block_to_inspect[END_LINE]: | ||
block_name = block_to_inspect.get('displayName', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pattern matching of Python 3.10 would be great here 😄 good enough for now 👍
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
For Azure pipelines, create a report with a formatted resource name indicating the path to the error path in the file.
So if the error comes from the second step in the
FailSetSecretVariable
job:The resource name would be:
/azure-pipelines.yaml:jobs.FailSetSecretVariable.steps[1]
Checklist: