platform(general): rationalize policy metadata error handling behavior #3795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This change causes checkov to fail if the user uses a platform API key, but the connection itself fails (e.g. SSL or auth error), and they don't use
--include-all-checkov-checks
.Today, the behavior is that the policy metadata download will fail with an error, but then the run will proceed. However, Checkov thinks all the policies are local policies, and does not run any of them (by design when using an API key). The result is blank output (minus the connection error message in the logs). This causes issues primarily in the IDEs, where there is no error message popup from the failed run, so it just looks like nothing happened.
This change will cause the run to actually fail if no policies are going to get evaluated.
It also handles some general conflicting logic with the use of
--skip-download
, which causes similar behavior (but without an error).Checklist: