Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets): Add multiline detection to entropy keyword combinator #3788

Merged
merged 9 commits into from
Nov 3, 2022

Conversation

marynaKK
Copy link
Contributor

@marynaKK marynaKK commented Nov 3, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • changed the logic of parsing yml files (part of changes of IAC secret detection): secret and keyword appearing in the context of a line should be also parsed as a pair, and the secret should be detected.

for IAC files only keyword combination is supported. this addition supports also multiline combination.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@nimrodkor nimrodkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marynaKK Very nice job!

checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
tests/secrets/resources/cfn/test-multiline-secrets.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@nimrodkor nimrodkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will move all yaml related methods to OOP to allow easier implementations for other extensions in another PR. GJ!

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, work, just have some minor comments

checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
checkov/secrets/plugins/entropy_keyword_combinator.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶

@marynaKK marynaKK merged commit ff59fcf into master Nov 3, 2022
@marynaKK marynaKK deleted the add-multiline-secret-detector branch November 3, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants