Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): render list entries via modules correctly #3781

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 31, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • the example in linked issue explains the problem pretty well. we actually render the value, but we don't pass to the config attribute, therefore we still think it is unrendered, when we run any checks against it.
  • during implementation I encountered various side effects, that's why I needed to write more code than expected

Fixes #3766

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel merged commit fcaf014 into bridgecrewio:master Nov 3, 2022
@gruebel gruebel deleted the render-list-entries branch November 3, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform module Checks Error
3 participants