-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): split repo and org webhooks to separate files #3764
Conversation
BaseVCSDAL.persist(path=self.github_conf_file_paths["repository_webhooks"], conf=repository_webhooks) | ||
for idx, item in enumerate(repository_webhooks): | ||
path = str(self.github_conf_file_paths["repository_webhooks"]) | ||
BaseVCSDAL.persist(path=path.replace(".json", str(idx) + ".json"), conf=[item]) # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some logs here for path=path.replace(".json", str(idx) + ".json")
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the logs inside the persist method, so we'll know what we're writing and to where
What about repo webhooks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share an example of the new output?
Example output:
|
Description
This PR splits multiple vcs webhooks into separate files so each one appears as new check violation.
Checklist: