Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): skip scanning VCS configuration if only files are passed in #3729

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 24, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • currently we scan any json file passed in via -f flag vor VCS configuration, which we shouldn't do 😄

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel merged commit b616c24 into bridgecrewio:master Oct 25, 2022
@gruebel gruebel deleted the ignore-files-in-vcs-scan branch October 25, 2022 07:59
gruebel added a commit to gruebel/checkov that referenced this pull request Oct 25, 2022
…d in (bridgecrewio#3729)

skip scanning VCS configuration if only files are passed in
gruebel added a commit to gruebel/checkov that referenced this pull request Oct 25, 2022
…d in (bridgecrewio#3729)

skip scanning VCS configuration if only files are passed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants