Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): fix in CPURequests check #3727

Merged
merged 3 commits into from
Oct 24, 2022
Merged

fix(kubernetes): fix in CPURequests check #3727

merged 3 commits into from
Oct 24, 2022

Conversation

YaaraVerner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

handle edge-case of res not a dict

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ChanochShayner
ChanochShayner approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@YaaraVerner YaaraVerner merged commit d6d634b into master Oct 24, 2022
@YaaraVerner YaaraVerner deleted the fix-in-CPURequests-check branch October 24, 2022 13:35
gruebel pushed a commit to gruebel/checkov that referenced this pull request Oct 24, 2022
@YaaraVerner @schosterbarak
fix(kubernetes): fix in CPURequests check (bridgecrewio#3727)
7da2016 
* handle edge-case of res not a dict

* fixes

* fixes
gruebel pushed a commit to gruebel/checkov that referenced this pull request Oct 24, 2022
@YaaraVerner @schosterbarak
fix(kubernetes): fix in CPURequests check (bridgecrewio#3727)
26b5206 
* handle edge-case of res not a dict

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@PelegLi PelegLi PelegLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaaraVerner @PelegLi @ChanochShayner